-
-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kubo-migrator: add migration from 12 to 13 #209304
Conversation
this fails because ld-linux.so is missing
not practical, as this will compile go_1_16 = slow the fix is as simple as ipfs/fs-repo-migrations#163 |
From reading what you linked to, it sounds like you ran
This is not true, everything is still in the cache. To test for yourself: git checkout 4c3c80df545ec5cb26b5480979c3e3f93518cbe5
nix-build -A ipfs-migrator I got this commit hash from the list at https://channels.nix.gsc.io/nixpkgs-unstable/history. The timestamp is from a day before Go 1.16 was removed.
Thanks, I will try to incorporate this patch into this PR when I have some time. |
see my PR
yes
i run nix-shell -p ipfs kubo-migrator # aka: ipfs-migrator
which fs-repo-migrations
# /nix/store/af47hh83i6awalxhrfdpr40gks5cm0fi-kubo-migrator-2.0.2/bin/fs-repo-migrations
ipfs daemon so ipfs should use it works with nix-shell -p ipfs kubo-migrator-all-fs-repo-migrations
which fs-repo-11-to-12
# /nix/store/60fnfclibg8mn0f0s55yv6v07dz7vh4c-kubo-migrator-all-fs-repo-migrations-12.1.0.2/bin/fs-repo-11-to-12
ipfs daemon |
419a9e9
to
4ec0f34
Compare
Ok, it should work now, thanks again for the patch. |
Two old migrations were broken since Go 1.16 was removed from Nixpkgs. Upstream is not interested in fixing the migrations to work with newer Go versions: ipfs/fs-repo-migrations#163 (comment).
https://github.com/ipfs/fs-repo-migrations/releases/tag/fs-repo-12-to-13%2Fv1.0.0 This will be used to upgrade the Kubo repo when updating to Kubo 0.18.
4ec0f34
to
9c87860
Compare
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
Description of changes
https://github.com/ipfs/fs-repo-migrations/releases/tag/fs-repo-12-to-13%2Fv1.0.0
This will be used to upgrade the Kubo repo when updating to Kubo 0.18.
Two old migrations were broken since Go 1.16 was removed from Nixpkgs.
Upstream is not interested in fixing the migrations to work with newer Go versions: ipfs/fs-repo-migrations#163 (comment).
Things done
sandbox = true
set innix.conf
? (See Nix manual)nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)nixos/doc/manual/md-to-db.sh
to update generated release notes